Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
Backups
youtube-dl
Commits
ce2fe4c0
Unverified
Commit
ce2fe4c0
authored
May 20, 2019
by
Sergey M․
Browse files
[extractor/common] Add doc string for _apply_first_set_cookie_header
parent
a9e03736
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
9 deletions
+13
-9
youtube_dl/extractor/common.py
youtube_dl/extractor/common.py
+13
-9
No files found.
youtube_dl/extractor/common.py
View file @
ce2fe4c0
...
@@ -2818,15 +2818,19 @@ class InfoExtractor(object):
...
@@ -2818,15 +2818,19 @@ class InfoExtractor(object):
return
compat_cookies
.
SimpleCookie
(
req
.
get_header
(
'Cookie'
))
return
compat_cookies
.
SimpleCookie
(
req
.
get_header
(
'Cookie'
))
def
_apply_first_set_cookie_header
(
self
,
url_handle
,
cookie
):
def
_apply_first_set_cookie_header
(
self
,
url_handle
,
cookie
):
# Some sites (e.g. [1-3]) may serve two cookies under the same name
"""
# in Set-Cookie header and expect the first (old) one to be set rather
Apply first Set-Cookie header instead of the last. Experimental.
# than second (new). However, as of RFC6265 the newer one cookie
# should be set into cookie store what actually happens.
Some sites (e.g. [1-3]) may serve two cookies under the same name
# We will workaround this issue by resetting the cookie to
in Set-Cookie header and expect the first (old) one to be set rather
# the first one manually.
than second (new). However, as of RFC6265 the newer one cookie
# 1. https://new.vk.com/
should be set into cookie store what actually happens.
# 2. https://github.com/ytdl-org/youtube-dl/issues/9841#issuecomment-227871201
We will workaround this issue by resetting the cookie to
# 3. https://learning.oreilly.com/
the first one manually.
1. https://new.vk.com/
2. https://github.com/ytdl-org/youtube-dl/issues/9841#issuecomment-227871201
3. https://learning.oreilly.com/
"""
for
header
,
cookies
in
url_handle
.
headers
.
items
():
for
header
,
cookies
in
url_handle
.
headers
.
items
():
if
header
.
lower
()
!=
'set-cookie'
:
if
header
.
lower
()
!=
'set-cookie'
:
continue
continue
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment