Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
Backups
youtube-dl
Commits
54a3a882
Unverified
Commit
54a3a882
authored
Jan 09, 2017
by
Yen Chi Hsuan
Browse files
[__init__] Metadata should be added after conversion
Fixes #5594
parent
92cb5763
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
3 deletions
+9
-3
ChangeLog
ChangeLog
+4
-0
youtube_dl/__init__.py
youtube_dl/__init__.py
+5
-3
No files found.
ChangeLog
View file @
54a3a882
version <unreleased>
Core
* [__init__] Metadata are now added after conversion (#5594)
Extractors
* [openload] Fix extraction (#10408, #12357)
...
...
youtube_dl/__init__.py
View file @
54a3a882
...
...
@@ -242,14 +242,11 @@ def _real_main(argv=None):
# PostProcessors
postprocessors
=
[]
# Add the metadata pp first, the other pps will copy it
if
opts
.
metafromtitle
:
postprocessors
.
append
({
'key'
:
'MetadataFromTitle'
,
'titleformat'
:
opts
.
metafromtitle
})
if
opts
.
addmetadata
:
postprocessors
.
append
({
'key'
:
'FFmpegMetadata'
})
if
opts
.
extractaudio
:
postprocessors
.
append
({
'key'
:
'FFmpegExtractAudio'
,
...
...
@@ -279,6 +276,11 @@ def _real_main(argv=None):
})
if
not
already_have_thumbnail
:
opts
.
writethumbnail
=
True
# FFmpegMetadataPP should be run after FFmpegVideoConvertorPP and
# FFmpegExtractAudioPP as containers before conversion may not support
# metadata (3gp, webm, etc.)
if
opts
.
addmetadata
:
postprocessors
.
append
({
'key'
:
'FFmpegMetadata'
})
# XAttrMetadataPP should be run after post-processors that may change file
# contents
if
opts
.
xattrs
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment